Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.schwifty: unbreak -- add missing dependency #309512

Merged
merged 1 commit into from May 6, 2024
Merged

python311Packages.schwifty: unbreak -- add missing dependency #309512

merged 1 commit into from May 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 6, 2024

importlib-resources is required for python 3.11 and older.

https://hydra.nixos.org/build/258264345
ZHF: #309482

https://github.com/mdomke/schwifty/blob/2024.04.0/pyproject.toml

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

importlib-resources is required for python 3.11 and older.
@mweinelt mweinelt merged commit 8f65060 into NixOS:master May 6, 2024
6 of 7 checks passed
@ghost ghost deleted the schwifty-fix branch May 6, 2024 09:21
@ofborg ofborg bot requested a review from milibopp May 6, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant